rdblue commented on code in PR #18884:
URL: https://github.com/apache/iceberg/pull/18884#discussion_r4569769146


##########
core/src/main/java/org/apache/iceberg/FilePlanner.java:
##########
@@ -163,6 +168,14 @@ CloseableIterable<FileScanTask> planFiles() {
     return CloseableIterable.transform(dataFiles, this::createTask);
   }
 
+  private static void rejectColumnFiles(TrackedFile entry) {

Review Comment:
   I think this makes the most sense in `asDataFile`. `DataFile` is the public 
API interface that will expose column files and it currently does not handle 
column files. When column files are available through that API, we can relocate 
the check to engines that do not support applying column files. But we can't do 
that until the API exposes it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to