kevinjqliu commented on code in PR #18663:
URL: https://github.com/apache/iceberg/pull/18663#discussion_r4569598032


##########
kafka-connect/build.gradle:
##########
@@ -73,6 +73,11 @@ 
project(':iceberg-kafka-connect:iceberg-kafka-connect-runtime') {
   configurations {
     hive {
       extendsFrom runtimeClasspath
+      // keep the hive distribution a superset of main by resolving shared 
jars to the same versions
+      shouldResolveConsistentlyWith(runtimeClasspath)
+      // SLF4J 1.x bindings are ignored by slf4j-api 2.x
+      exclude group: 'ch.qos.logback'
+      exclude group: 'org.slf4j', module: 'slf4j-reload4j'

Review Comment:
   @danielcweeks had a comment about this in 
https://github.com/apache/iceberg/pull/18660#discussion_r4541394406
   
   `logback-classic` and `slf4j-reload4j` are SLF4J 1.x bindings, which 
slf4j-api 2.0 ignores. Both are only in `hive`, so this excludes them and drops 
the Logback entry from `hive/LICENSE`. See the diff in `hive/runtime-deps.txt` 
in this PR.



##########
kafka-connect/build.gradle:
##########
@@ -73,6 +73,11 @@ 
project(':iceberg-kafka-connect:iceberg-kafka-connect-runtime') {
   configurations {
     hive {
       extendsFrom runtimeClasspath
+      // keep the hive distribution a superset of main by resolving shared 
jars to the same versions
+      shouldResolveConsistentlyWith(runtimeClasspath)
+      // SLF4J 1.x bindings are ignored by slf4j-api 2.x
+      exclude group: 'ch.qos.logback'
+      exclude group: 'org.slf4j', module: 'slf4j-reload4j'

Review Comment:
   reverted this to keep the PR focused on LICENSE/NOTICE. will exclude them 
from `hive` in a follow up



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to