gaborkaszab commented on code in PR #18884:
URL: https://github.com/apache/iceberg/pull/18884#discussion_r4568065432


##########
core/src/main/java/org/apache/iceberg/FilePlanner.java:
##########
@@ -163,6 +168,14 @@ CloseableIterable<FileScanTask> planFiles() {
     return CloseableIterable.transform(dataFiles, this::createTask);
   }
 
+  private static void rejectColumnFiles(TrackedFile entry) {

Review Comment:
   If we reject this on the `DataFile` level, we won't be able to make any 
parallel progress with column files. My immediate follow-up after merging the 
metadata structs is exposing column files through the tracked file adapters 
([PR](https://github.com/apache/iceberg/pull/17127)). Without that, all we can 
do is private experiments.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to