kevinjqliu commented on code in PR #4328:
URL: https://github.com/apache/iceberg-python/pull/4328#discussion_r4567555975


##########
pyiceberg/encryption/manager.py:
##########


Review Comment:
   nit: not related to this pr, but generally i think we should compare using 
"version >= 3" instead of isinstance



##########
pyiceberg/io/fileformat.py:
##########
@@ -159,7 +160,10 @@ def create_writer(
         output_file: OutputFile,
         file_schema: Schema,
         properties: Properties,
-    ) -> FileFormatWriter: ...
+        key_metadata: StandardKeyMetadata | None = None,

Review Comment:
   hm on first thought, idk if it makes sense to have `key_metadata` as a param 
here. 
   
   maybe we can shove it into the properties bag...
   
   thoughts? 
   
   i'll do some prompting and testing to see which is better 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to