gaborkaszab commented on code in PR #18924:
URL: https://github.com/apache/iceberg/pull/18924#discussion_r4563662988


##########
core/src/test/java/org/apache/iceberg/TestRowLineageMetadata.java:
##########
@@ -109,14 +110,38 @@ public void testSnapshotRowIDValidation() {
     assertThatThrownBy(
             () ->
                 new BaseSnapshot(
-                    0, 1, null, 0, DataOperations.APPEND, null, 1, "ml.avro", 
null, 0L, -1L, null))
+                    0 /* sequenceNumber */,

Review Comment:
   This and the one below exceeded the line length, so now that the params are 
broken into separate lines, I added comments to the constant values.



##########
core/src/main/java/org/apache/iceberg/RewriteTablePathUtil.java:
##########
@@ -241,8 +241,14 @@ private static List<Snapshot> updatePathInSnapshots(
       TableMetadata metadata, String sourcePrefix, String targetPrefix) {
     List<Snapshot> newSnapshots = 
Lists.newArrayListWithCapacity(metadata.snapshots().size());
     for (Snapshot snapshot : metadata.snapshots()) {
+      if (snapshot.rootManifestLocation() != null) {

Review Comment:
   I think e should simply reject this operation when we have root manifests. 
The reason is that if we rewrite the root manifests themselves, their size 
changes, but we don't have a mechanism to adjust the size to the new one below, 
when rewriting the snapshots.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to