dino-saurabh opened a new issue, #1117:
URL: https://github.com/apache/iceberg-cpp/issues/1117
`ManifestFilterManager::ShouldDelete` builds a new `StrictMetricsEvaluator`
and `InclusiveMetricsEvaluator` for every data file it checks
([manifest_filter_manager.cc#L366-L375](h
ttps://github.com/apache/iceberg-cpp/blob/19573767858c16cb64a19e5c20afb303b8c6ada6/src/iceberg/manifest/manifest_filter_manager.cc#L366-L375)).
`Make()` rewrites and binds the
expression each time, even though the residual only changes per partition.
The existing TODO already notes this:
> TODO(Guotao): Cache strict/inclusive metrics evaluators per partition
residual.
Measured with the benchmarks from #<PR>, building and evaluating per file
costs about 6x as much as evaluating with a prebuilt evaluator (16 predicates:
~9 µs vs ~1.5 µs per
file).
Proposal: cache the evaluators per partition residual, and add a benchmark
for the build-per-file case to measure the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]