dino-saurabh opened a new issue, #1118:
URL: https://github.com/apache/iceberg-cpp/issues/1118

   The generic `Visit` evaluates both children of `And`/`Or` before combining 
them
     
([expression_visitor.h#L313-L325](https://github.com/apache/iceberg-cpp/blob/19573767858c16cb64a19e5c20afb303b8c6ada6/src/iceberg/expression/expression_visitor.h#L313-L325)).
     Java's boolean evaluators use 
[`ExpressionVisitors.visitEvaluator`](https://github.com/apache/iceberg/blob/3c2407555f798ed11134e680e064cc87c4e4d2e3/api/src/main/java/org/apache/ic
     eberg/expressions/ExpressionVisitors.java#L387-L415), which skips the 
right side when the left side already decides the result.
   
     Affected: `Evaluator` (per row, via the residual filter in 
`FileScanTaskReader`), `InclusiveMetricsEvaluator` and `StrictMetricsEvaluator` 
(per data file), `ManifestEvaluator`
     (per manifest), and `ParquetMetricsRowGroupFilter` (per row group).
   
     Proposal: add a `VisitEvaluator` that mirrors Java's and use it in these 
evaluators. Generic `Visit` stays as is for visitors that must see every node. 
One behavior change to
     note: an error on the right side is no longer reported when the left side 
decides the result, as in Java.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to