gerashegalov commented on code in PR #18709: URL: https://github.com/apache/iceberg/pull/18709#discussion_r4562229489
########## spark/v4.2/spark/src/main/java/org/apache/iceberg/spark/source/metrics/EffectiveSplitTargetSize.java: ########## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.spark.source.metrics; + +import org.apache.spark.sql.connector.metric.CustomSumMetric; + +public class EffectiveSplitTargetSize extends CustomSumMetric { Review Comment: Done in d5c86a7df: `EffectiveSplitTargetSize` now implements `CustomMetric` directly, like `NumSplits`. The driver reports the value once per scan and it is not additive, so `aggregateTaskMetrics` returns the largest value instead of the sum. With a single driver value, the SQL UI shows the same number as before. I also removed the `effectiveSplitTargetSize > 0` checks from the V1/V2 read-metrics tests: they were left over from folding in the earlier test, and the dedicated tests already assert exact values. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
