jiwen624 commented on code in PR #18908: URL: https://github.com/apache/iceberg/pull/18908#discussion_r4559934484
########## core/src/main/java/org/apache/iceberg/util/SnapshotUtil.java: ########## Review Comment: Minor, and fine as a follow-up: when `snapshotId` is the table's current snapshot, this now throws `not an ancestor of table's current snapshot`, which is misleading, since Iceberg treats a snapshot as its own ancestor (`SnapshotUtil.isAncestorOf(table, id, id)` returns true). The real reason is that no newer snapshot exists yet. It can be either a separate check for the current snapshot or a reworded message. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
