namest504 commented on PR #18738:
URL: https://github.com/apache/iceberg/pull/18738#issuecomment-6843148339

   Thanks. The expire deletes now go into their own set. It is cleared whenever 
the updates are applied again on a refreshed base, and the files are deleted 
only after the commit succeeds. `cleanUp()` does not touch it, so point 2 is 
covered too. Done in a186004.
   
   For the test, the tag case does not get that far. `RemoveSnapshots` keeps 
the ids from the first attempt, so the retry fails with "Still referenced by 
refs: [keep]". I used a staged snapshot that gets cherry-picked while the 
transaction is open instead.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to