AP24110011695 commented on PR #4331: URL: https://github.com/apache/iceberg-python/pull/4331#issuecomment-6836328320
Applied both suggestions as-is (2e7bd68) — flipping the argument order is clearly better: the tie now keeps the existing value exactly like `PartitionFieldStats.update`, the guard reads as "an incoming zero of the wrong sign corrects the bound", and `previous` is gone. You were also right about the comment — the old one was accurate for the code I *should* have written. Verified unchanged behavior: all 22 StatsAggregator tests pass, and I re-probed the zero interleavings (both two-value orders plus `(0.0, -0.0, 0.0)` and `(-0.0, 0.0, -0.0)`) — every one produces the canonical `lower = to_bytes(-0.0)`, `upper = to_bytes(+0.0)` pair. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
