danielcweeks commented on code in PR #16425:
URL: https://github.com/apache/iceberg/pull/16425#discussion_r4554724045


##########
format/spec.md:
##########
@@ -88,7 +88,7 @@ This table format tracks individual data files in a table 
instead of directories
 
 Table state is maintained in metadata files. All changes to table state create 
a new metadata file and replace the old metadata with an atomic swap. The table 
metadata file tracks the table schema, partitioning config, custom properties, 
and snapshots of the table contents. A snapshot represents the state of a table 
at some time and is used to access the complete set of data files in the table.
 
-Data files in snapshots are tracked by one or more manifest files that contain 
a row for each data file in the table, the file's partition data, an optional 
colocated deletion vector (v4), and its metrics. The data in a snapshot is the 
union of all live files in its manifests; each live file may only appear once 
(see [Content file uniqueness](#content-file-uniqueness)). Manifest files are 
reused across snapshots to avoid rewriting metadata that is slow-changing. 
Manifests can track data files with any subset of a table and are not 
associated with partitions.
+Data files in snapshots are tracked by one or more manifest files that contain 
a row for each data file in the table, the file's partition data, an optional 
colocated deletion vector and optional column files (v4), and its metrics. The 
data in a snapshot is the union of all live files in its manifests; each live 
file may only appear once (see [Content file 
uniqueness](#content-file-uniqueness)). Manifest files are reused across 
snapshots to avoid rewriting metadata that is slow-changing. Manifests can 
track data files with any subset of a table and are not associated with 
partitions.

Review Comment:
   ```suggestion
   Data files in snapshots are tracked by one or more manifest files that 
contain a row for each data file in the table, the file's partition data, and 
starting in v4, an optional colocated deletion vector and optional column 
files, and its metrics. The data in a snapshot is the union of all live files 
in its manifests; each live file may only appear once (see [Content file 
uniqueness](#content-file-uniqueness)). Manifest files are reused across 
snapshots to avoid rewriting metadata that is slow-changing. Manifests can 
track data files with any subset of a table and are not associated with 
partitions.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to