fmorillo7694 commented on PR #17901:
URL: https://github.com/apache/iceberg/pull/17901#issuecomment-6828415655

   Thanks @mxm, and sorry this sat for a while. On your Oct 1 question: yes, 
`MaxCommittedCheckpointIdValidator` and its exception now live in `SinkUtil`.
   
   @ajanko-shopify, thanks a lot for #18916! I've pulled both of your commits 
into this PR, with your commit kept under your name plus a `Co-authored-by` 
trailer, so this branch is now identical to #18916: rebased on `main`, a 
per-caller snapshot predicate for #18303, and validation only after a restore, 
to match #18123. Would you mind closing #18916 in favour of this one, so the 
review stays in one place?
   
   One thing to watch: #18807 (sink ID for `IcebergSink`) merges cleanly with 
this as text, but it removes the `isRestored` flag this PR checks. Whichever 
lands second needs a small rebase. If #18807 goes first, I'll switch the 
validator to match on sink ID, like the new up-front check, which should also 
make the restore-only condition unnecessary.
   
   @mxm, could you take another look when you have a moment?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to