pvary commented on PR #18894: URL: https://github.com/apache/iceberg/pull/18894#issuecomment-6824381176
> A RESTSessionCatalog creates its own HTTPClient with a connection pool, auth session, FileIO and a one-thread rest-metrics-reporter pool per instance, and JdbcCatalog creates its own JdbcClientPool. The `clientBuilder` and the `clientPoolBuilder` is there for this exact reason. They might not be used, because it is not easy to decide when to reuse and when not reuse. I very often see this "reuse" Catalog, or "close" Catalog debate. We should close 😄 this forever and apply it consistently. I curious what other's think. CC: @nastra, @mxm, @Guosmilesmile -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
