vlad-lyutenko commented on code in PR #18910:
URL: https://github.com/apache/iceberg/pull/18910#discussion_r4550502023


##########
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##########
@@ -2110,9 +2110,11 @@ public void 
testCatalogTokenRefreshFailsAndUsesCredentialForRefresh(String oauth
                       any(),
                       any());
 
-              // verify the first token exchange - since an exception is 
thrown, we're performing
-              // retries
-              Mockito.verify(adapter, times(2))
+              // verify the first token exchange. The exchange throws and is 
retried, but the
+              // session knows the token expires 1s after it was issued (from 
expires_in), so the

Review Comment:
   refactored



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to