nastra commented on code in PR #18378:
URL: https://github.com/apache/iceberg/pull/18378#discussion_r4547897283
##########
core/src/test/java/org/apache/iceberg/rest/auth/TestAuthSessionCache.java:
##########
@@ -88,4 +88,15 @@ void cacheEviction() {
cache.close();
}
+
+ @Test
+ void noExecutorByDefault() {
+ AuthSessionCache cache = new AuthSessionCache("test", Duration.ofHours(1));
+ AuthSession session = Mockito.mock(AuthSession.class);
+ AuthSession cached = cache.cachedSession("key", k -> session);
+ assertThat(cached).isSameAs(session);
+
+ cache.close();
+ Mockito.verify(session, Mockito.timeout(30_000)).close();
+ }
Review Comment:
```suggestion
```
I would probably just remove this test. We don't want to add test flakiness
in case async execution takes longer than expected and I don't think it adds
too much value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]