geruh commented on code in PR #3285: URL: https://github.com/apache/iceberg-python/pull/3285#discussion_r4547189420
########## pyiceberg/table/update/validate.py: ########## Review Comment: looks like we also need to account for concurrent equality deletes from other engines here. We're using the head sequence instead of the operations starting sequence. Java: https://github.com/apache/iceberg/blob/e31ea5f39b3e7d4a536cad3a4dbdc16dcf1e1553/core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java#L530-L534 walk through this ^ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
