GayathriSrividya commented on PR #4346: URL: https://github.com/apache/iceberg-python/pull/4346#issuecomment-6817062443
> [@kevinjqliu](https://github.com/kevinjqliu) [@GayathriSrividya](https://github.com/GayathriSrividya) could you take a look when you have a chance? It changes which filters `_task_to_record_batches` pushes down to the Arrow scanner (the path [#3448](https://github.com/apache/iceberg-python/pull/3448) reworked) so row-group pruning no longer drops NaN rows. Thanks, Rahul! I've checked the follow-up changes. The NOT handling has been separated, and the float32 coverage is now included. My earlier feedback looks addressed. LGTM! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
