anoopj commented on code in PR #18884:
URL: https://github.com/apache/iceberg/pull/18884#discussion_r4543125567


##########
api/src/main/java/org/apache/iceberg/Snapshot.java:
##########
@@ -170,6 +170,16 @@ default Iterable<DeleteFile> removedDeleteFiles(FileIO io) 
{
    */
   String manifestListLocation();
 
+  /**
+   * Return the location of this snapshot's root manifest, or null if this 
snapshot has no root
+   * manifest.
+   *
+   * @return the location of the root manifest for this Snapshot
+   */
+  default String rootManifestLocation() {

Review Comment:
   > This overlaps with @stevenzwu 's #17523
   
   Yes, I called this out in the PR description. 
   
   >  shouldn't we introduce all the new V4 snapshot fields in one PR?
   
   It would be really nice to get v4 reads working without encryption. If the 
snapshot changes with encryption gets merged first, we can just delete the 
first commit from this PR. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to