Perseus commented on code in PR #3283:
URL: https://github.com/apache/iceberg-rust/pull/3283#discussion_r4537731882
##########
crates/iceberg/src/arrow/caching_delete_file_loader.rs:
##########
@@ -421,18 +423,34 @@ impl CachingDeleteFileLoader {
let input_file = basic_delete_file_loader
.file_io()
.new_input(task.file_path())?;
- let blob = match task.key_metadata() {
+ let key_metadata = task
+ .key_metadata()
+ .map(StandardKeyMetadata::decode)
+ .transpose()?;
+ let count_reads = |reader| -> Box<dyn FileRead> {
Review Comment:
I tried to single-line it, but the formatter always adds a `{}` around the
call if the line is too long; I could single-line it by creating a variable for
`metrics` but that felt unneccessary since `metrics` isn't used anywhere else.
I simplified it a bit, but I can do single-line it if you feel strongly about
this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
