stevenzwu commented on code in PR #18853:
URL: https://github.com/apache/iceberg/pull/18853#discussion_r4528954237
##########
core/src/test/java/org/apache/iceberg/V4TestHelpers.java:
##########
@@ -204,14 +237,74 @@ static OutputFile writeTrackedFiles(
Types.StructType statsType,
Iterable<TrackedFile> files)
throws IOException {
- Schema writeSchema = TrackedFile.schema(partitionType, statsType);
- try (FileAppender<StructLike> appender =
- InternalData.write(format,
out).schema(writeSchema).named("tracked_file").build()) {
+ try (FileAppender<StructLike> appender = newAppender(out, format,
partitionType, statsType)) {
for (TrackedFile file : files) {
appender.add((StructLike) file);
}
}
return out;
}
+
+ static OutputFile writeRows(
Review Comment:
`writeRows` is added because the wrappers now only implement `StructLike`
(per the review on `TrackedFileWrapper`), so they can no longer be passed to
`writeTrackedFiles`, which takes `TrackedFile`. It writes `StructLike` rows the
same way a v4 manifest writer will consume the wrappers, and shares the
appender setup with `writeTrackedFiles`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
