gaborkaszab commented on code in PR #18486: URL: https://github.com/apache/iceberg/pull/18486#discussion_r4530319587
########## api/src/main/java/org/apache/iceberg/HasReferencedFiles.java: ########## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +/** An object that references content files. */ +public interface HasReferencedFiles { Review Comment: The other approach I was exploring did avoid API changes, however had a switch on the `ScanTask` type inside `InputFilesDecryptor`. We can move that to a utility class, but I wasn't that comfortable because of the switch. [This is how it looked like](https://github.com/apache/iceberg/pull/18486/changes/d31e5105e2460e322b721e3bb0ac7a8fbec2666c#diff-5afae55416e7b4ff94167ea1cc73f79328bccf3b4f777adc7ebd948a42899560R80) before, we could move that to a utility or leave it in the decryptor class. The next step in my thought process was, if we solve the problem at the right level and for me it seemed that the `ScanTasks` should tell us themselves what files they reference. What I still think is that the `referencedFiles` logic should be removed from the readers to make it uniform. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
