Revanth14 commented on PR #2502: URL: https://github.com/apache/iceberg-go/pull/2502#issuecomment-6776829688
> Thanks @Revanth14 — this lines up with Java's `AuthManagers` and `GoogleAuthManager`: case-insensitive `rest.auth.type`, built-in `none`/`oauth2`, the same `gcp.auth.*` properties and default scope, and resolution from client properties only, before `/v1/config`, with a test showing server overrides can't change it. Merged with current `main`, `go mod tidy` is a no-op, `go vet ./...` (also `-tags integration ./catalog/...`) is clean, `go test ./...` passes, the auth and `googleauth` tests pass under `-race`, and `catalog/rest` still links no Google auth packages. > > One thing before approval: the Google token refresh uses its own `http.Client` with the default transport, so a custom transport, TLS, or proxy configured on the catalog doesn't apply to token requests. That matches Java, but please add a sentence to the BigLake section of `website/src/configuration.md` (and the `googleauth` package doc) saying so, and that users who need a specific client can put it in the context's `oauth2.HTTPClient` value or build the token source themselves with `WithAuthManager`. > > Separately, `AuthManagerConfig` being a struct leaves room to pass the catalog's HTTP client to factories later if that's wanted; no change needed here. > > > _This review was drafted by an AI-assisted tool and confirmed by an Apache Iceberg Go maintainer. The findings below are observations, not blockers; an Apache Iceberg Go maintainer — a real person — will take the next look at the PR. If you think a finding is mis-applied, please reply on the PR and a maintainer will weigh in._ > > _More on how Apache Iceberg Go handles maintainer review:_ [CONTRIBUTING.md](https://github.com/apache/iceberg-go/blob/main/CONTRIBUTING.md). Thanks for the review @zeroshade addressed the feedback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
