fallintoplace opened a new pull request, #2508: URL: https://github.com/apache/iceberg-go/pull/2508
## What - Reject out-of-range string casts to nanosecond timestamp types. ## Why - `UnixNano()` wraps outside the signed 64-bit range. ## Implementation - Check the parsed time before converting it. ## References - [Iceberg spec: primitive types](https://iceberg.apache.org/spec/#primitive-types) - [Java `Literals`](https://github.com/apache/iceberg/blob/main/api/src/main/java/org/apache/iceberg/expressions/Literals.java#L2645-L2657) - [Java `DateTimeUtil`](https://github.com/apache/iceberg/blob/main/api/src/main/java/org/apache/iceberg/util/DateTimeUtil.java#L899-L901) - This covers string parsing; [#2500](https://github.com/apache/iceberg-go/pull/2500) covers microsecond conversion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
