zeroshade commented on PR #2476: URL: https://github.com/apache/iceberg-go/pull/2476#issuecomment-6773533507
Thanks. The README change is right, and I agree with @badalprasadsingh: please make the same change to the `integration-env` target in the Makefile (`echo "export AWS_S3_ENDPOINT=http://localhost:9000"`). CI doesn't use that target; `go-integration.yml` sets its own endpoint from the `minio` container, so this won't affect CI. It also matches what `recipe.Start` uses. With that, the comment in `hadoop_s3_integration_test.go` pointing to `make integration-env` is accurate as is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
