pvary commented on code in PR #18717:
URL: https://github.com/apache/iceberg/pull/18717#discussion_r4524358815
##########
flink/v2.3/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/EqualityConvertPlanner.java:
##########
@@ -410,17 +601,18 @@ private boolean indexReflects(Snapshot mainSnapshot) {
* only after this returns. Neither the next trigger nor a restore from a
checkpoint taken after a
* rebuild that failed part way trusts the index it left.
*/
- private void rebuildIndex(Snapshot mainSnapshot, boolean evictStaleKeys) {
+ private void rebuildIndex(Snapshot mainSnapshot) {
+ LOG.info(
+ "Reindexing worker index from main snapshot {} for field IDs {}.",
+ mainSnapshot.snapshotId(),
+ eqFieldIds);
+
indexSnapshotId = null;
long generation = indexGeneration + 1;
-
- if (evictStaleKeys) {
- output.collect(
- CLEAR_BROADCAST_STREAM,
- new StreamRecord<>(
- IndexCommand.clearBeforeReindex(mainSnapshot.snapshotId(),
generation)));
- reindexCounter.inc();
- }
+ output.collect(
Review Comment:
We start to count, an log the first index as a `reindex`. Is this
intentional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
