FenjuFu opened a new pull request, #1106: URL: https://github.com/apache/iceberg-cpp/pull/1106
The Windows C++20 and C++23 example steps reuse example/build. Give each standard a separate directory (build/cxx20 and build/cxx23) so the second build does not remove binaries from the first. Validate that the standard is numeric before using it in a directory name. Refs #1101; dependency downloads and sccache finalization are outside this change. Validation: - bash -n and targeted pre-commit pass. - A real Bash before/after harness with stubbed CMake and simulated locked-directory removal fails on the original and passes with the change. Four invalid standard inputs are rejected before directory creation. - Full pre-commit was attempted: the EOF hook changed CLAUDE.md, a Git symlink checked out as a regular file on Windows. That unrelated change was restored; the other hooks passed. - Full Iceberg compilation and a real Windows file-lock reproduction have not been run. AI assistance was used to draft the change and validation harness. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
