gerashegalov commented on PR #18709: URL: https://github.com/apache/iceberg/pull/18709#issuecomment-6759812433
> Do we need to cover SparkChangelogScan as well? @manuzhang I would keep it out of this PR. `SparkChangelogScan` does not extend `SparkScan` and reports no driver metrics today, not even the scan-report ones. It also never adapts its split size: `planTasks()` uses the read option or the table property, so the value is already known from configuration. The metric is meant to expose the adaptive target that batch scans compute at planning time. If changelog scans get driver metrics later, this one can be added with them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
