kumarpritam863 commented on code in PR #18739:
URL: https://github.com/apache/iceberg/pull/18739#discussion_r4520133905


##########
flink/v2.3/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicIcebergSink.java:
##########
@@ -298,6 +309,37 @@ public Builder<T> tableCreator(TableCreator 
tableCreationFunction) {
       return this;
     }
 
+    /**
+     * Set a consumer for the error stream of records that fail during 
conversion/table update. When
+     * set, a record that fails in the generator, schema evolution, or table 
update is routed to

Review Comment:
   Reworded. A failure thrown by DynamicRecordGenerator#generate itself is not 
diverted, and TestDynamicRecordProcessor#doesNotDivertFailureOfGenerator covers 
it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to