jiwen624 commented on PR #18846: URL: https://github.com/apache/iceberg/pull/18846#issuecomment-6754090643
> With these two call sites gone, the filtered `validateNoNewDeletesForDataFiles(base, startingSnapshotId, dataFilter, dataFiles, parent)` overload has no callers left; `MergingSnapshotProducer` is package-private, so it could go here or in a follow-up. Thanks for the review and for reproducing it! I'd keep the overload: although MergingSnapshotProducer is package-private, the method is protected and inherited by the public BaseOverwriteFiles/BaseRowDelta, which have protected constructors, so external subclasses can still call it. revapi tracks these inherited methods too, so removing it would need a deprecation cycle. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
