slfan1989 commented on PR #2460: URL: https://github.com/apache/iceberg-go/pull/2460#issuecomment-6753190985
> Thanks — running the same `UpgradeFormatVersion` validation for dry runs makes the preview fail exactly when the real upgrade would on an unsupported or lower version, and validating before the confirmation prompt means a non-dry run no longer asks for confirmation of an upgrade that then fails. The dry-run no-commit test still passes, and `./cmd/iceberg` passes merged with current `main`. > > > _This review was drafted by an AI-assisted tool and confirmed by an Apache Iceberg Go maintainer. The maintainer approving this PR has read the findings and signed off. If something feels off, please reply on the PR and a maintainer will follow up._ > > _More on how Apache Iceberg Go handles maintainer review:_ [CONTRIBUTING.md](https://github.com/apache/iceberg-go/blob/main/CONTRIBUTING.md). Thanks for reviewing and merging this pr! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
