sungwy commented on code in PR #18080:
URL: https://github.com/apache/iceberg/pull/18080#discussion_r4518699964


##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -1410,12 +1410,34 @@ paths:
       - $ref: '#/components/parameters/prefix'
       - $ref: '#/components/parameters/namespace'
       - $ref: '#/components/parameters/table'
+      - $ref: '#/components/parameters/data-access'
 
     post:
       tags:
         - Catalog API
       summary: Remotely signs requests to object storage
       operationId: signRequest
+      description: >

Review Comment:
   Hi @adutra, sorry for the confusion, and thanks for catching this. The 
pre-signing client in #18110 wrongly sends the storage location 
(`s3://bucket/key`), which leaves the http url conversion to the server. That 
was my initial assumption, but as you said, it makes sense to keep the semantic 
consistent with existing remote-signing: the client builds the request URL, and 
the server only signs the request, for both mechanisms this endpoint supports.
   
   I have a branch in progress that does this, which I'll force-push to 
#18110's branch once it's ready: 
https://github.com/sungwy/iceberg/compare/main...presign-from-client-v2. It 
builds on #17457's HTTP read path, so the first commit in that is William's 
change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to