nssalian commented on code in PR #2375:
URL: https://github.com/apache/iceberg-go/pull/2375#discussion_r4517050701
##########
table/variant_shredded_write_test.go:
##########
@@ -792,12 +794,17 @@ func columnPhysicalType(t *testing.T, path, name string)
parquet.Type {
sc := pf.MetaData().Schema
for i := range sc.NumColumns() {
if col := sc.Column(i); col.Name() == name {
- return col.PhysicalType()
+ return col.PhysicalType(), col.LogicalType()
}
}
t.Fatalf("column %q not found", name)
- return parquet.Types.Undefined
+ return parquet.Types.Undefined, nil
+}
+
+// appendVariantInt32 appends v as a variant int32, bypassing AppendInt's
smallest-width encoding.
+func appendVariantInt32(b *variant.Builder, v int32) error {
Review Comment:
Done. `NullFieldKeepsBound` and `AddFilesBounds` now decode the bound and
check its type and value. I dropped `int-small` from `ScalarBounds`, since
`SmallSampleKeepsWideBound` covers it with a decoded check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
