sam-1112 commented on PR #3632:
URL: https://github.com/apache/iceberg-rust/pull/3632#issuecomment-6747788544

   @mbutrovich Thanks for the detailed review! I've addressed all four points:
   - Changed `coerce_int96_timestamps` to return `Result<Option<_>>` and 
propagate errors through both callers. Added tests for `ListView` traversal 
failure and mismatched leaf counts.
   - Removed the projection-mask helper and assertions, keeping the full batch 
comparisons.
   - Reused `write_int96_parquet_file` for the `timestamp` and `timestamptz` 
cases, including name mapping and year-3333 values. The separate nanosecond 
fixture now uses `parse_message_type`, without the missing-field/default cases.
   - Removed the INT64 exclusion assertion. 
`test_only_int96_timestamps_are_coerced` still verifies that non-INT96 types 
remain unchanged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to