jbonofre commented on code in PR #15212:
URL: https://github.com/apache/iceberg/pull/15212#discussion_r4516071171
##########
kafka-connect/kafka-connect-runtime/src/main/resources/manifest.json:
##########
@@ -35,7 +35,7 @@
"logo": "assets/iceberg.png",
"type": "organization",
"url": "https://iceberg.apache.org";,
- "username": "iceberg"
+ "username": "apache"
Review Comment:
Following up on this: the current Confluent Hub listing (linked in the PR
description) is `iceberg/iceberg-kafka-connect`. With `owner.username` set to
`apache`, the component becomes `apache/iceberg-kafka-connect`, which is a
different listing.
Users running `confluent-hub install iceberg/iceberg-kafka-connect:latest`
would not get new versions, and the connector would end up split across two
listings (in theory).
That's fine because we didn't publish yet, but just to note 😄
##########
deploy.gradle:
##########
@@ -75,6 +76,8 @@ subprojects {
} else if (isOpenApi) {
artifact testJar
artifact testFixturesJar
+ } else if (isKafkaConnectRuntime) {
+ artifact distZip
Review Comment:
With `distZip` as the only unclassified artifact, Gradle derives the POM
packaging from it, so the published POM should end with
`<packaging>zip</packaging>` and no `-sources.jar` / `-javadoc.jar` alongside.
Central requires sources and javadoc jars for any packaging other than
`pom`, and the close of the staging repository on repository.apache.org can
reject it for that, which would block the RC.
Can you check the output of `generatePomFileForApachePublication` for this
module?
Two ways to fix it:
- add `artifact sourceJar` and `artifact javadocJar` (both tasks are already
created for this project above), or
- set `pom.packaging = 'pom'` and publish the zip with a classifier.
If the `hive` distribution is added here as @kevinjqliu suggested, a
classified `hive` zip doesn't change this: the main zip remains the
unclassified artifact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
