RussellSpitzer commented on code in PR #18477:
URL: https://github.com/apache/iceberg/pull/18477#discussion_r4515300703


##########
spark/v4.2/spark/src/main/java/org/apache/iceberg/spark/actions/BaseSparkAction.java:
##########
@@ -407,14 +410,29 @@ public long totalFilesCount() {
 
   private static class ReadManifest implements 
FlatMapFunction<ManifestFileBean, FileInfo> {
     private final Broadcast<Table> table;
+    private final SetAccumulator<String> missingManifests;
 
-    ReadManifest(Broadcast<Table> table) {
+    ReadManifest(Broadcast<Table> table, SetAccumulator<String> 
missingManifests) {

Review Comment:
   I am not a big fan of methods/ or classes which behave differently based on 
whether arguements are set or unset. Here I think it would be very unclear to a 
caller as to what setting this actually did and since it's wired into a lot of 
actions right now that's a bit of surface area for further coders. 
   
   I suggested just logging on failure before so we probably don't need this 
accumulator at all if we go that route? 
   
   I would probably just have ExpireSnapshotsAction just have a special 
extension of ReadManifest which skips to avoid polluting all the other callers.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to