adutra commented on code in PR #18754:
URL: https://github.com/apache/iceberg/pull/18754#discussion_r4511413335


##########
docs/docs/rest-catalog.md:
##########
@@ -110,17 +110,42 @@ The following properties configure the table cache used 
for freshness-aware tabl
 
 Most deployments require authentication, which is specific to the catalog
 service. The following catalog properties configure the potential
-authentication mechanisms: Basic, OAuth2, SigV4, and Google.
+authentication mechanisms: Basic, Bearer, OAuth2, SigV4, and Google.
 
 ### REST auth properties
 
 | Property                             | Default          | Description        
                                                                                
               |
 
|--------------------------------------|------------------|-------------------------------------------------------------------------------------------------------------------|
-| `rest.auth.type`                     | `none`           | Authentication 
mechanism for REST catalog access. Supported values: `none`, `basic`, `oauth2`, 
`sigv4`, `google`. |
+| `rest.auth.type`                     | `none`           | Authentication 
mechanism for REST catalog access. Supported values: `none`, `basic`, `bearer`, 
`oauth2`, `sigv4`, `google`. |
 | `rest.auth.basic.username`           | null             | Username for Basic 
authentication. Required if `rest.auth.type` = `basic`.                         
               |
 | `rest.auth.basic.password`           | null             | Password for Basic 
authentication. Required if `rest.auth.type` = `basic`.                         
               |
 | `rest.auth.sigv4.delegate-auth-type` | `oauth2`         | Auth type to 
delegate to after `sigv4` signing.                                              
                     |
 
+### Bearer auth properties
+Required and optional properties to include while using `bearer` authentication
+
+The `bearer` auth manager sets an `Authorization: Bearer <token>` header on 
every request, as defined in
+[RFC 6750](https://www.rfc-editor.org/rfc/rfc6750). It never contacts an 
authorization server and never refreshes
+the token: obtaining and renewing the token is the responsibility of an 
external process, such as a Kubernetes
+[projected service account 
token](https://kubernetes.io/docs/tasks/configure-pod-container/configure-service-account/#launch-a-pod-using-service-account-token-projection),
+a sidecar like Vault Agent, or a script.
+
+| Property                                      | Default | Description        
                                                                                
                                                                          |
+|-----------------------------------------------|---------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| `rest.auth.bearer.token-file`                 | null    | Path to a local 
file containing the bearer token. The file is re-read periodically. Exactly one 
of `rest.auth.bearer.token-file` or `rest.auth.bearer.token` is required.    |
+| `rest.auth.bearer.token`                      | null    | A static bearer 
token. Exactly one of `rest.auth.bearer.token-file` or `rest.auth.bearer.token` 
is required.                                                                 |

Review Comment:
   Good catch, will do!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to