blackmwk commented on code in PR #3514:
URL: https://github.com/apache/iceberg-rust/pull/3514#discussion_r4511440320
##########
crates/iceberg/src/scan/mod.rs:
##########
@@ -143,15 +143,11 @@ pub struct TableScanBuilder<'a> {
// Defaults to none which means select all columns
column_names: Option<Vec<String>>,
snapshot_selection: Option<SnapshotSelection>,
- batch_size: Option<usize>,
case_sensitive: bool,
filter: Option<Predicate>,
- concurrency_limit_data_files: usize,
concurrency_limit_manifest_entries: usize,
concurrency_limit_manifest_files: usize,
- row_group_filtering_enabled: bool,
- row_selection_enabled: bool,
- bloom_filter_enabled: bool,
+ concurrency_limit_data_files: usize,
Review Comment:
I don't think we should keep this, it's part of arrow reader options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
