zhjwpku commented on code in PR #1104:
URL: https://github.com/apache/iceberg-cpp/pull/1104#discussion_r4510950767
##########
src/iceberg/update/merging_snapshot_update.cc:
##########
@@ -921,6 +919,12 @@ Result<std::vector<ManifestFile>>
MergingSnapshotUpdate::WriteNewDeleteManifests
return result;
}
+Status MergingSnapshotUpdate::PrepareForReplay() {
+ // The same path can inherit new sequence numbers and row IDs on replay.
+ // Drop derived caches, but keep their files staged for terminal cleanup.
+ return CleanUncommittedManagers({});
Review Comment:
I share the same concern with copilot, maybe a follow-up: add
sequence_number, min_sequence_number and first_row_id of the inputs to the
cache key, and only rebuild when they differ.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
