mxm commented on code in PR #18752: URL: https://github.com/apache/iceberg/pull/18752#discussion_r4490617205
########## site/docs/community.md: ########## @@ -143,7 +143,9 @@ Many contributors have questions about how to become a committer. This section o ### What are the responsibilities of a committer? -In the Iceberg project, committers are community members that can review and commit changes to Iceberg repositories. Reviewing is the primary responsibility of committers. +Committers are project reviewers and are able to commit code in Iceberg repositories. Reviewing is the primary responsibility of committers. + +Although ASF write access applies across all project repositories, committers are trusted to merge PRs or commit only in areas and Iceberg implementations where they are knowledgeable. When contributing to or reviewing changes outside their area of expertise or in another implementation, committers should work with maintainers of that codebase and get a review from someone familiar with the area before merging. Review Comment: "maintainers of that codebase" sounds like there are assigned committers to components. I'd rephrase to say "already experienced committers in that codebase". See below: ```suggestion Although ASF write access applies across all project repositories, committers are trusted to merge PRs or commit only in areas and Iceberg implementations where they are knowledgeable. When contributing to or reviewing changes outside their area of expertise or in another implementation, committers should work with already experienced committers in that codebase to get a review from someone familiar with the area before merging. ``` ########## site/docs/community.md: ########## @@ -143,7 +143,9 @@ Many contributors have questions about how to become a committer. This section o ### What are the responsibilities of a committer? -In the Iceberg project, committers are community members that can review and commit changes to Iceberg repositories. Reviewing is the primary responsibility of committers. +Committers are project reviewers and are able to commit code in Iceberg repositories. Reviewing is the primary responsibility of committers. Review Comment: "project reviewers" is a bit vague. I'd clarify their role a bit more. See below: ```suggestion Committers are project members who have the authority to commit code to Iceberg repositories. With this authority comes the responsibility to help maintain the project's quality, stability, and overall direction. Reviewing contributions is therefore their primary responsibility. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
