kevinjqliu commented on code in PR #3644:
URL: https://github.com/apache/iceberg-rust/pull/3644#discussion_r4495767716


##########
.asf.yaml:
##########
@@ -109,6 +109,17 @@ github:
     creation_cap:
       enabled: true
       max_open_pull_requests: 3
+      # The cap is not applied to these contributors. ASF makes GitHub's 
bypass list
+      # match this list exactly, so a login added by hand in the repository 
settings
+      # is removed on the next sync. An unknown login fails the whole sync.

Review Comment:
   > An unknown login fails the whole sync.
   
   i manually checked every user name listed here, everything is valid 



##########
CONTRIBUTING.md:
##########
@@ -42,6 +42,8 @@ Once your changes are ready you must submit your branch as a 
[pull request](http
 
 With coding agents, the number of open PRs now far exceeds our review 
capacity. To help reviewers focus on fewer PRs, users without write access are 
limited to **3 open, non-draft PRs** at a time. If you've reached the limit, 
wait for existing PRs to be merged, close some of them, or convert some to 
drafts until you have fewer than three open PRs before opening another.
 
+Contributors who have shown sustained engagement with the project can be 
exempted from the limit. The exemptions are listed under `bypass_users` in 
[`.asf.yaml`](https://github.com/apache/iceberg-rust/blob/main/.asf.yaml). To 
ask for one, email [email protected]. Exempt contributors should open 
lower-priority or blocked PRs as drafts so reviewers can see where to focus.

Review Comment:
   ```suggestion
   Contributors who have shown sustained engagement with the project can be 
exempted from the limit. The exemptions are listed under `bypass_users` in 
[`.asf.yaml`](https://github.com/apache/iceberg-rust/blob/main/.asf.yaml). 
Exempt contributors should open lower-priority or blocked PRs as drafts so 
reviewers can see where to focus.
   ```
   
   i dont think we should advertise asking to be added on the devlist... maybe 
slack? or something else?



##########
.asf.yaml:
##########
@@ -109,6 +109,17 @@ github:
     creation_cap:
       enabled: true
       max_open_pull_requests: 3
+      # The cap is not applied to these contributors. ASF makes GitHub's 
bypass list
+      # match this list exactly, so a login added by hand in the repository 
settings
+      # is removed on the next sync. An unknown login fails the whole sync.
+      bypass_users:
+        - JanKaul
+        - c-thiel
+        - mbutrovich
+        - CTTY

Review Comment:
   ```suggestion
   ```
   
   we can kick shawn out, he has write access and already exempt 😄 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to