linzch3 commented on code in PR #4275:
URL: https://github.com/apache/iceberg-python/pull/4275#discussion_r4475122435
##########
tests/test_transforms.py:
##########
@@ -513,6 +513,14 @@ def test_truncate_method(type_var: PrimitiveType, value:
Any, expected_human_str
assert truncate_transform.satisfies_order_of(truncate_transform)
+def test_truncate_satisfies_order_of_different_widths() -> None:
Review Comment:
sure! ported `testSatisfiesTruncateFieldOrder` from `TestSortOrder.java` in
the Java repo, same 5 assertions (identity vs truncate, truncate(4) vs
truncate(2) and the reverse). pyiceberg doesn't have `SortOrder.satisfies` yet
so they're checked straight on `satisfies_order_of`, as a parametrized test.
kept the equal-width and truncate-vs-bucket cases from before too. the test
fails on main and passes with the fix (｡•ᴗ•｡)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
