Guosmilesmile commented on code in PR #18807:
URL: https://github.com/apache/iceberg/pull/18807#discussion_r4477430042
##########
flink/v2.3/flink/src/main/java/org/apache/iceberg/flink/sink/SinkUtil.java:
##########
@@ -82,6 +83,40 @@ static Set<Integer> checkAndGetEqualityFieldIds(Table table,
List<String> equali
return equalityFieldIds;
}
+ static long getMaxCommittedCheckpointIdBySink(
Review Comment:
Agreed that the duplication exists, but I'd prefer to keep this PR focused
on the IcebergSink sinkId fix.
Since DynamicCommitter is in a different package, sharing the lookup still
requires a public method. The refactoring would also involve changes to
ancestor handling and summary keys, making the scope larger than necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
