rambleraptor commented on code in PR #167:
URL:
https://github.com/apache/terraform-provider-iceberg/pull/167#discussion_r4473746249
##########
docs/resources/table.md:
##########
@@ -117,6 +117,7 @@ schema = {
### Optional
- `partition_spec` (Attributes) The partition spec of the table. (see [below
for nested schema](#nestedatt--partition_spec))
+- `purge_on_destroy` (Boolean) Whether destroying the resource also deletes
the table's data and metadata files. Catalogs such as Amazon S3 Tables reject a
drop without purge. Defaults to `false`.
Review Comment:
```suggestion
- `purge_on_destroy` (Boolean) Whether destroying the resource also deletes
the table's data and metadata files. Defaults to `false`.
```
##########
internal/provider/resource_table.go:
##########
@@ -114,6 +117,12 @@ func (r *icebergTableResource) Schema(_ context.Context, _
resource.SchemaReques
Computed: true,
ElementType: types.StringType,
},
+ "purge_on_destroy": rscschema.BoolAttribute{
+ Description: "Whether destroying the resource
also deletes the table's data and metadata files. Catalogs such as Amazon S3
Tables reject a drop without purge. Defaults to `false`.",
Review Comment:
```suggestion
Description: "Whether destroying the resource
also deletes the table's data and metadata files. Defaults to `false`.",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
