ajreid21 commented on code in PR #17912:
URL: https://github.com/apache/iceberg/pull/17912#discussion_r4499888718
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -1320,7 +1320,17 @@ private FileIO tableFileIO(
RemoteSigningConfigParser.toJson(remoteSigningConfig));
}
- return newFileIO(context, fullConf.buildKeepingLast(), storageCredentials);
+ Map<String, String> ioProperties =
Maps.newHashMap(fullConf.buildKeepingLast());
+ ioProperties.remove(RESTCatalogProperties.CREDENTIALS_ENDPOINT);
+ if (!storageCredentials.isEmpty()) {
Review Comment:
what happens if a credentials endpoint returns just basic keys without
session token or expiry? won't VendedCredentialsProvider just reject those?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
