jopdorp commented on PR #3300: URL: https://github.com/apache/iceberg-rust/pull/3300#issuecomment-6683355333
@blackmwk restacked on #3564 with 4aa7e9e48. The action only builds a `MergingIntent` now and the producer does the manifest work, so against that branch the diff is the action, four tests and the wiring. @laskoviymishka two things differ from what you reviewed, both because they live in the producer now: 1. Deletes match by path only, like the producer and Java, so the check that record count, size and partition also match is gone. 2. A missing delete path still fails the commit, but the producer's filter checks it after it wrote its rewritten manifests, not before. They are tracked for the #3417 cleanup. I raised it on #3564. Re-adding a path deleted in the same overwrite is kept, with its test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
