vladislav-sidorovich commented on PR #16848: URL: https://github.com/apache/iceberg/pull/16848#issuecomment-6704870828
> That said, this PR doesn't hurt anything, but I'm not convinced it's really fixing any major issue. Are there any know threaded scenarios where this would prevent some sort of race condition? Catalogs are initialized as a single thread, which creates the auth manager. I can't envision any scenario where this needs to be thread safe. Thanks for the review @danielcweeks! I've addressed the clean-up items. I hope there is no serious impact in known clients today since RESTSessionCatalog initializes on a single thread. However, this is still a bug relative to the clear intent of the library. As seen in #14178 standalone components can call AuthManager#tableSession(RESTClient, Map) concurrently from multiple threads. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
