yayaha opened a new pull request, #18819: URL: https://github.com/apache/iceberg/pull/18819
`client.refresh-credentials-enabled` and `gcs.oauth2.refresh-credentials-enabled` control whether vended credentials are refreshed. Both default to `true`. The scheduled refresh in `S3FileIO` and `GCSFileIO` (#15678, #15696) does not check these properties. When refresh is disabled, it still schedules the refresh and sends a request to the catalog's credentials endpoint. This change skips the scheduled refresh when the property is `false`. The default behavior does not change. With a REST catalog, the `S3FileIO` scheduled refresh fails today (#17810). #17912 fixes it, so `S3FileIO` with a REST catalog also sends these requests once #17912 merges. Testing: added `noScheduledRefreshWhenRefreshIsDisabled` to `TestS3FileIOCredentialRefresh` and `TestGCSFileIOCredentialRefresh`. --- **AI Disclosure** - Model: Claude Opus 5.5 - Platform/Tool: Claude Code - Human Oversight: partially reviewed (skimmed through tests) - Prompt Summary: Make the scheduled credential refresh in `S3FileIO` and `GCSFileIO` respect the refresh-enabled properties, with tests. This pull request and its description were written by Isaac. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
