huaxingao commented on code in PR #18776: URL: https://github.com/apache/iceberg/pull/18776#discussion_r4496789155
########## api/src/main/java/org/apache/iceberg/Constraint.java: ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import java.io.Serializable; + +/** + * A constraint declares a property that a table's rows are expected to satisfy. + * + * <p>A constraint's definition is stored in table metadata and references the fields it applies to Review Comment: `TableMetadata` is in the core module, so the Javadoc in api can't link to it with `{@link}`. I added `{@code TableMetadata}` and a link to the table metadata section of the spec instead. I will also link `Table#constraints()` in the follow-up PR that adds it to the `Table` API. ########## api/src/main/java/org/apache/iceberg/Constraint.java: ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import java.io.Serializable; + +/** + * A constraint declares a property that a table's rows are expected to satisfy. + * + * <p>A constraint's definition is stored in table metadata and references the fields it applies to + * by field ID, so it keeps applying after columns are renamed or reordered. The concrete subtype is Review Comment: Removed. The field ID details are already in `KeyConstraint` and `CheckConstraint`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
