xanderbailey commented on code in PR #4159:
URL: https://github.com/apache/iceberg-python/pull/4159#discussion_r4496856539
##########
pyiceberg/table/snapshots.py:
##########
@@ -289,9 +290,21 @@ def __repr__(self) -> str:
filtered_fields = [field for field in fields if field is not None]
return f"Snapshot({', '.join(filtered_fields)})"
- def manifests(self, io: FileIO) -> list[ManifestFile]:
- """Return the manifests for the given snapshot."""
- return list(_manifests(io, self.manifest_list))
+ def manifests(self, io: FileIO, encryption_manager: EncryptionManager |
None = None) -> list[ManifestFile]:
Review Comment:
Take
[b0b4160](https://github.com/apache/iceberg-python/pull/4159/commits/b0b41606ff08b42ab4e0ccda93027363649a2f46)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
